Skip to content

Partial search fix (amended) #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cvonkleist wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Partial search fix (amended) #8

cvonkleist wants to merge 1 commit into from

Conversation

@cvonkleist
Copy link

@cvonkleist cvonkleist commented Mar 9, 2017

This PR fixes the following issues in pull request #6 by @smntb:

  • Get rid of whitespace edits (indentation, etc.) which made the diff very large — ~7,000 lines
  • Don't revert pear_isError() to PEAR::isError() — recent PEAR::isError() cannot be called this way
  • Rebase all commits on top of current dev branch

@cvonkleist cvonkleist mentioned this pull request Mar 9, 2017
Closed
@cvonkleist
Copy link
Author

cvonkleist commented Mar 9, 2017

I haven't had time to fully test this code. I'd like to spend some time testing it with more production data before merging it into our fork of Archon. I hope that's okay. 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cvonkleist @smntb